Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digest Auth Support #119 #817

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

drinkbird
Copy link
Contributor

@drinkbird drinkbird commented Oct 29, 2023

Description

Enables the use of Digest as an additional authentication option.

Limitations:

  • Supports the MD5 algorithm only.
  • Supports username and password input only. No advanced parameterization.

Guidance required:

  1. What is the best place to add automated tests for Digest?
  2. How can I verify this PR doesn't introduce breaking changes?
  3. I'm only familiar with the UI usage and need some help verifying Bru Lang / Collection Runner / CLI

Screenshots:

Get request - Auth and Vars defined in the request.
Digest-get

Post request - Auth defined in the collection, Vars defined in the environment.
Digest-collection
Digest-collection-post

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes.
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request. -> Aiming to be added to API / Collection Authorization #119

@drinkbird drinkbird changed the title Add Digest Auth Support #119 Add Digest Auth Support Oct 29, 2023
@drinkbird drinkbird changed the title Add Digest Auth Support Add Digest Auth Support #119 Oct 29, 2023
@helloanoop helloanoop merged commit 64923e4 into usebruno:main Nov 3, 2023
@helloanoop
Copy link
Contributor

This is Awesome!

Thanks for adding Digest Auth to Bruno @drinkbird !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants