Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cronjob cleanup use matching function instead of regex #244

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: cronjob cleanup use matching function instead of regex #244

merged 1 commit into from
Oct 17, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Oct 17, 2023 •
edited
Loading

Just fixes up the cronjob cleanup calculation step to be clearer without using regex pattern matching to ensure cleanups are handled.

@shreddedbacon shreddedbacon marked this pull request as ready for review October 17, 2023 03:42
tobybellwood
tobybellwood approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward change, reording the process, and tightening up the previous regex matching. Tested working in Jenkins setup

Approved.

@shreddedbacon shreddedbacon merged commit 1882d5d into main Oct 17, 2023
@shreddedbacon shreddedbacon deleted the cronjob-cleanup-fixes branch October 17, 2023 06:24
@shreddedbacon shreddedbacon mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood