Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use robfigcron for validation after lagoon replacements #368

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

shreddedbacon
Copy link
Member

Just replaces the cron validation logic to use robfig/cron to do the final validation. This is what kubernetes uses under the hood in the cronjob controller.

Only the lagoon pseudo random seed replacements are performed and updates the schedule before handing off to be validated.

@shreddedbacon shreddedbacon added this to the 2.21.0 milestone Sep 14, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review September 15, 2024 22:04
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it simplifies the process a little, and adds standardisation.

The test cases have it well covered.

@shreddedbacon shreddedbacon merged commit 7ad87f8 into main Sep 15, 2024
2 checks passed
@shreddedbacon shreddedbacon deleted the refactor-cron-validation branch September 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants