fix: use LAGOON_ENVIRONMENT_VARIABLES as primary source #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketeerbkw
force-pushed
the
org-env-vars
branch
from
1ecd6d9 to
8d275c8
Compare
Eventually LAGOON_PROJECT_VARIABLES will be empty
rocketeerbkw
force-pushed
the
org-env-vars
branch
from
8d275c8 to
911c544
Compare
shreddedbacon
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
This looks fine to me. Incorporating the backwards compatible project variable check on the necessary variables solves the main concern.
As this is compatible with the current version of lagoon with uselagoon/lagoon#3856 not yet merged (at the time of review) this is fine to be merged without the other being merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In uselagoon/lagoon#3856, Lagoon core will consolidate env vars before sending to Lagoon remote, so LAGOON_PROJECT_VARIABLES may be empty.