Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set error_log location for containerization #663

Closed
wants to merge 1 commit into from
Closed

Set error_log location for containerization #663

wants to merge 1 commit into from

Conversation

mxr576
Copy link

@mxr576 mxr576 commented Jan 18, 2023

Closes #662

@mxr576 mxr576 changed the title Set error_log configuration for containerization Set error_log location for containerization Jan 18, 2023
mxr576
mxr576 commented Jan 19, 2023
View reviewed changes
images/php-fpm/00-lagoon-php.ini.tpl
@@ -8,6 +8,7 @@ display_startup_errors = ${PHP_DISPLAY_STARTUP_ERRORS:-Off}
auto_prepend_file = ${PHP_AUTO_PREPEND_FILE:-none}
auto_append_file = ${PHP_AUTO_APPEND_FILE:-none}
error_reporting = ${PHP_ERROR_REPORTING:-E_ALL & ~E_DEPRECATED & ~E_STRICT}
error_log=${PHP_ERROR_LOG:-/proc/self/fd/2}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I have deployed the test image that was built by the CI from this PR to a Lagoon environment and in the CLI container I get

[foobar]test@cli-drupal:/app$ php -i | grep error_log
error_log => /proc/self/fd/2 => /proc/self/fd/2

but admin/reports/status/php says error_log is unset...

mxr576
mxr576 commented Jan 19, 2023
View reviewed changes
images/php-fpm/php-fpm.d/global.conf
@@ -5,3 +5,5 @@
; Default Unit: seconds
; Default Value: 0
process_control_timeout = 30s

error_log = ${PHP_ERROR_LOG:-/proc/self/fd/2}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still the same...

@rocketeerbkw
Copy link
Member

We think this is working correctly already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw Awaiting requested review from rocketeerbkw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP error_log configuration is missing
2 participants
@mxr576 @rocketeerbkw