Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update disallow public visibility setting name #3687

Merged
merged 1 commit into from
Jul 14, 2024
Merged

chore: update disallow public visibility setting name #3687

merged 1 commit into from
Jul 14, 2024

Conversation

johnnyjoygh
Copy link
Collaborator

disallow_public_visible to disallow_public_visibility

@johnnyjoygh johnnyjoygh requested a review from boojack as a code owner July 14, 2024 12:20
boojack
boojack approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@boojack boojack merged commit 7c9e54a into main Jul 14, 2024
5 checks passed
@boojack boojack deleted the chore/update-memo-disallow-public-visibility-name branch July 14, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyjoygh @boojack