This repository was archived by the owner on Mar 19, 2025. It is now read-only.
Never redirect after login when setting up TOTP #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
RJFelix
approved these changes
Mar 8, 2024
Contributor
RJFelix
left a comment
RJFelix
left a comment
There was a problem hiding this comment.
This fixes the bug, thanks - see my question about whether we need to redirect within Toolkit after they're done with their backup codes, though!
| } | ||
|
|
||
| // Don't redirect after TOTP setup so backup codes can be shown | ||
| arg.redirect = false; |
Contributor
There was a problem hiding this comment.
Do we need to explicitly redirect after they confirm they've gotten the codes?
Contributor
Author
There was a problem hiding this comment.
It redirects to the after signup path after you hit continue.
Contributor
|
Published version 1.0.8-alpha.0 to npm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Level: Glance
Closes: DEV-1085
Never redirect after login when setting up TOTP. Had to move the argument out of the if statement.