Skip to content

Commit

Permalink
Fix #951 - User Model forceDelete doesn't remove the record from the DB
Browse files Browse the repository at this point in the history
  • Loading branch information
lcharette committed Apr 8, 2019
1 parent 764de35 commit 3790e4f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Italian translation ([#950])
- User Registration failing when trying to register two accounts with the same email address ([#953])
- Bad test case for `CoreController::getAsset`.
- User Model `forceDelete` doesn't remove the record from the DB ([#951])

## [v4.2.0]
### Changed Requirements
Expand Down Expand Up @@ -712,6 +713,7 @@ See [http://learn.userfrosting.com/upgrading/40-to-41](Upgrading 4.0.x to 4.1.x
[#919]: https://github.com/userfrosting/UserFrosting/issues/919
[#940]: https://github.com/userfrosting/UserFrosting/issues/940
[#950]: https://github.com/userfrosting/UserFrosting/issues/950
[#951]: https://github.com/userfrosting/UserFrosting/issues/951
[#953]: https://github.com/userfrosting/UserFrosting/issues/953

[v4.2.0]: https://github.com/userfrosting/UserFrosting/compare/v4.1.22...v4.2.0
Expand Down
2 changes: 1 addition & 1 deletion app/sprinkles/account/src/Database/Models/User.php
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public function delete($hardDelete = false)
// TODO: remove any persistences

// Delete the user
$result = parent::forceDelete();
$result = $this->forceDelete();
} else {
// Soft delete the user, leaving all associated records alone
$result = parent::delete();
Expand Down

0 comments on commit 3790e4f

Please sign in to comment.