Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bakery options for: smtp:<port>, secure:<true|false>, auth:<true|false> #1067

Closed
waldenn opened this issue Mar 5, 2020 · 3 comments
Closed
Labels
bakery Related to the Bakery feature core feature request Feature request good first issue Good for newcomers mail Email related up-for-grabs Not assigned yet
Milestone

Comments

@waldenn
Copy link

waldenn commented Mar 5, 2020

In order to make the email functionality work on my SMTP server (which forwards emails to a secure ISP relay), I had to make these changes in the userfrosting/app/sprinkles/core/config/default.php:

'port' => 25,
'auth' => false,
'secure' => 'false'

Please consider adding these options to the setup options (and documentation).
I had to create a PHPMailer application to debug my SMTP connection problem, hopefully other people can avoid that with these settings.

Thanks for a great user management framework!

@waldenn waldenn changed the title Add Bakery options for: smtp:port, secure:false and auth:false Add Bakery options for: smtp:port, secure:<true|false> and auth:<true|false> Mar 5, 2020
@waldenn waldenn changed the title Add Bakery options for: smtp:port, secure:<true|false> and auth:<true|false> Add Bakery options for: smtp:<port>, secure:<true|false> and auth:<true|false> Mar 5, 2020
@waldenn waldenn changed the title Add Bakery options for: smtp:<port>, secure:<true|false> and auth:<true|false> Add Bakery options for: smtp:<port>, secure:<true|false>, auth:<true|false> Mar 5, 2020
@lcharette lcharette added bakery Related to the Bakery feature core feature request Feature request good first issue Good for newcomers mail Email related up-for-grabs Not assigned yet labels Mar 6, 2020
@lcharette lcharette added this to the 4.3.x milestone Mar 6, 2020
@gyaaniguy
Copy link

I am going for a PR. How should this be ideally handled ?

@lcharette
Copy link
Member

lcharette commented Apr 6, 2020

@gyaaniguy Thanks!

I see three things that needs to be done :

  1. Add new ENV variables to .env.example
  2. Implement said variables to the config file
  3. Add the new options to the SetupSmtpCommand Bakery command.

A PR for this can be sent on the hotfix branch. See your Contributing page for more info :)

@lcharette lcharette linked a pull request Apr 8, 2020 that will close this issue
@lcharette lcharette modified the milestones: 4.4.x, 4.5.0, 4.x.x Apr 22, 2020
@lcharette lcharette modified the milestones: 4.5.0, 4.6.0 Nov 14, 2020
@lcharette lcharette modified the milestones: 4.5.0, 4.x.x Mar 5, 2021
@mikkoaf
Copy link

mikkoaf commented Jun 10, 2021

I was looking through up-for-grabs issues.

I found out that the linked, closed PR #1077 was merged to master in 82a1706 and is included on the release https://github.com/userfrosting/UserFrosting/releases/tag/v4.5.0

Can this issue be closed or is there still work to be done?

@waldenn waldenn closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bakery Related to the Bakery feature core feature request Feature request good first issue Good for newcomers mail Email related up-for-grabs Not assigned yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants