More SMTP options in config #1067 #1077
Conversation
lcharette
added
bakery
Codecov Report
@@ Coverage Diff @@
## hotfix #1077 +/- ##
============================================
- Coverage 67.57% 67.39% -0.19%
- Complexity 1976 1991 +15
============================================
Files 170 170
Lines 6917 6937 +20
============================================
+ Hits 4674 4675 +1
- Misses 2243 2262 +19
Continue to review full report at Codecov.
|
| 'port' => getenv('SMTP_PORT') ?: null, | ||
| 'auth' => getenv('SMTP_AUTH') ?: null, | ||
| 'secure' => getenv('SMTP_SECURE') ?: null, // Enable TLS encryption. Set to `tls`, `ssl` or `false` (to disabled) |
There was a problem hiding this comment.
Hum... This would create a breaking change for people without those settings already in their env, which push this change to UF 4.5. I wonder if there's a way to keep the default here, and overwrite in the env?
| $smtpAuth = ($input->getOption('smtp_auth')) ?: $this->io->ask('SMTP Server Authentication', 'true'); | ||
| $smtpSecure = ($input->getOption('smtp_secure')) ?: $this->io->ask('SMTP Server Security type', 'tls'); |
There was a problem hiding this comment.
A yes/no question or choices could probably better here.
|
I would maybe try to make it consistent with Laravel's environment variables? See https://github.com/laravel/laravel/blob/master/.env.example |
|
I manually merged in 82a1706 as I wasn't able to update the original branch. I manually fixed the comments and conflict at the same time. |
Added SMTP port, SMTP authentication type , and SMTP security protocol to config file. So that it can be set from .env file.
I did not get a chance to test it. Apologies if I did something incorrect.