Locale matcher can fail when client provided locale identifier has incorrect casing

[Silic0nS0ldier]

UserFrosting/app/sprinkles/core/src/I18n/SiteLocale.php

Lines 172 to 186 in f1d0d7a

	if (in_array(strtolower($identifier), array_map('strtolower', $availableLocales))) {
	// Determine preference level (q=0.x), and add to $foundLocales
	// If no preference level, set as 1
	if (array_key_exists(1, $parts)) {
	$preference = str_replace('q=', '', $parts[1]);
	$preference = (float) $preference; // Sanitize with int cast (bad values go to 0)
	} else {
	$preference = 1;
	}
	// Add to list, and format for UF's i18n.
	$foundLocales[$identifier] = $preference;
	}
	}

We need to update how the identifier to handled to ensure issues don't occur on case sensitive file systems. Ideally the value used would come from the locale matcher array to avoid excessive value processing.

[Silic0nS0ldier]

Entirely untested prototype fix

                    // Ensure locale available
                    $localeIndex = array_search(strtolower($identifier), array_map('strtolower', $availableLocales));
                    if ($localeIndex !== -1) {
                        $matchedLocale = $availableLocales[$localeIndex];
                        // Determine preference level (q=0.x), and add to $foundLocales
                        // If no preference level, set as 1
                        if (array_key_exists(1, $parts)) {
                            $preference = str_replace('q=', '', $parts[1]);
                            $preference = (float) $preference; // Sanitize with int cast (bad values go to 0)
                        } else {
                            $preference = 1;
                        }

                        // Add to list, and format for UF's i18n.
                        $foundLocales[$matchedLocale] = $preference;
                    }

[lcharette]

Isn't that handled by the strtolower ? Can you give an example of a input value where it wouldn't work ?

[lcharette]

Ok I see. A test with en-us instead of en-US would be required here :

UserFrosting/app/sprinkles/core/tests/Integration/I18n/SiteLocaleTest.php

Line 167 in f1d0d7a

$request->shouldReceive('getHeaderLine')->with('Accept-Language')->once()->andReturn('en-US, en;q=0.9, fr;q=0.8, de;q=0.7, *;q=0.5');