-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Composer 2 #1117
Comments
We should be able to fix this now by upgrading |
And raising our minimum PHP version from 7.1 to 7.2 (as per plugin requirements). Otherwise looks to a fairly straightforward update thankfully. |
We're still supporting 7.1? Might as well release 4.5 while at it. Do you have any other change / BC that requires a major bump ? |
Yeah, NodeJS for ESM support. Not ready for prime time yet, but raising will let it release more easily. |
Care to push the required change to develop and/or open PR? I'll see if I can release this fix over the weekend. |
Sure. I'll see about getting it up this afternoon (my time, so in around 9 hours). |
I've opened #1138 |
This issue is fixed in ab33733 on develop for 4.5.0 release. |
This is dependent of an issue with wikimedia/composer-merge-plugin, and can only be solved once wikimedia/composer-merge-plugin#189 (comment) is merged and released.
Other reference : wikimedia/composer-merge-plugin#184
The text was updated successfully, but these errors were encountered: