Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer2 fix #1120

Closed
wants to merge 5 commits into from
Closed

Composer2 fix #1120

wants to merge 5 commits into from

Conversation

lcharette
Copy link
Member

Related to #1117. Testing fix from wikimedia/composer-merge-plugin#189. Should probably stay in draft until official wikimedia/composer-merge-plugin is released.

@lcharette lcharette added the compatibility Compatibility issue with other framework, features label Nov 20, 2020
@lcharette lcharette added this to the 4.4.x milestone Nov 20, 2020
@lcharette lcharette linked an issue Nov 20, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #1120 (9a0c8e2) into hotfix (9467ddf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1120   +/-   ##
=========================================
  Coverage     67.81%   67.81%           
  Complexity     1981     1981           
=========================================
  Files           170      170           
  Lines          6926     6926           
=========================================
  Hits           4697     4697           
  Misses         2229     2229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9467ddf...ccd37d3. Read the comment docs.

@lcharette lcharette closed this Nov 23, 2020
@lcharette
Copy link
Member Author

image Travis ans it's limitations when comes to using VCS repo with composer... I did test manually on the VM and the temp fix works for now. I'll still wait for the official release.

@lcharette lcharette removed this from the 4.5.x milestone Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility issue with other framework, features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Composer 2
1 participant