Config can't remove unwanted available locales

[lcharette]

Setting the available locale in a sprinkle config file to remove the unwanted locale won't work. This only replace the locale displayed name.

            'locales' => [
                'available' => [
                    'fr_FR' => 'Français'
                ],
            ]

To solve this issue, available locale should only be an array of locale code ('available' => ['fr_FR', 'en_US']) and the locale name should be define elsewhere (locale metadata for example).

(Related to #671)

[alexweissman]

As a short-term solution, what if userfrosting/config had a getDefined method that did the same thing as get, but then removed any keys from the sub-array that are assigned to null?

So then you could do:

            'locales' => [
                'available' => [
                    'fr_FR' => 'Français',
                    'en_US' => null,
                    'de_DE' => null,
                    ...
                ],
            ]

Then you could call $config->getDefined('site.locales.available') and it would strip out those null-valued keys.

[lcharette]

I guess it could work. Any reason it couldn't be done in normal get? db/laravel settings?

[alexweissman]

I mean, we could always do an array_walk or something to filter them out in the config service.

[lcharette]

See #682 for a temp fix.

[alexweissman]

The more general problem here is the ability for a schema/config/whatever file loaded in a later Sprinkle, to remove (rather than simply overwrite) content from a previously loaded Sprinkle.

The question is, do we want to have something in the syntax of the files themselves that can do this? Otherwise, I think my getDefined approach might be the best.

[alexweissman]

I'm going to close this because it's technically been fixed with the Repository::getDefined method.

The broader discussion about the correct way to store and load locale metadata can be continued in this issue: userfrosting/i18n#4