User Registration fails when trying to register two accounts with the same email address

[lcharette]

Ref.: https://forums.userfrosting.com/t/php-error-undefined-variable-if-new-user-registration-fails/507/1

The simplest way to reproduce is to try to register two accounts with the same email address. Note this doesn't happens when creating a user manually through the admin panel.

Error message:

{
    "message": "Call to a member function toArray() on null",
    "exception": [
        {
            "type": "Error",
            "code": 0,
            "message": "Call to a member function toArray() on null",
            "file": "\/home\/vagrant\/UserFrosting\/app\/sprinkles\/account\/src\/Controller\/AccountController.php",
            "line": 926
        }
    ]
}

[lcharette]

That's new level of bad code. If an exception is thrown, a success is still displayed 🤦‍♂️

UserFrosting/app/sprinkles/account/src/Controller/AccountController.php

Lines 916 to 932 in d312d1f

	try {
	$user = $registration->register();
	} catch (\Exception $e) {
	$ms->addMessageTranslated('danger', $e->getMessage(), $data);
	$error = true;
	}
	// Success message
	if ($config['site.registration.require_email_verification']) {
	// Verification required
	$ms->addMessageTranslated('success', 'REGISTRATION.COMPLETE_TYPE2', $user->toArray());
	} else {
	// No verification required
	$ms->addMessageTranslated('success', 'REGISTRATION.COMPLETE_TYPE1');
	}
	return $response->withJson([], 200);