Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit password schema field name #1034

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Conversation

phillmac
Copy link
Contributor

The input name in the rendered modal is password instead of value
See

<input type="password" class="form-control" name="password" autocomplete="off" value="" placeholder="{{translate('PASSWORD.BETWEEN', {min: 12, max: 50})}}">

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #1034 into hotfix will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1034   +/-   ##
=========================================
  Coverage     66.66%   66.66%           
  Complexity     1931     1931           
=========================================
  Files           162      162           
  Lines          6737     6737           
=========================================
  Hits           4491     4491           
  Misses         2246     2246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebf4ca...ac40d15. Read the comment docs.

@lcharette
Copy link
Member

I think the whole confusion here might comes from the upateField controller method. This method can accept any fields, one or more, and update it, and at some point used value for something...

I think there might also be something wrong in the controller, as $fieldName is defined twice. I'll have to check out what cause that :

@phillmac
Copy link
Contributor Author

phillmac commented Sep 16, 2019

The set password schema is for generating the client side validation rules as the domain is set to client so it should never be loaded in a controller except for rendering the modal

@lcharette lcharette self-assigned this Sep 26, 2019
@lcharette lcharette added the confirmed bug Something isn't working label Sep 26, 2019
@lcharette lcharette added this to the 4.3.x milestone Sep 26, 2019
@rwos rwos mentioned this pull request Oct 1, 2019
@lcharette lcharette merged commit 99f383b into userfrosting:hotfix Nov 17, 2019
lcharette added a commit that referenced this pull request Nov 17, 2019
Removed `value` as the default field name when editing a single field. 
The field name should now be the proper name. For example, editing 
`flag_enable`, the data should be `flag_enabled => 1` instead of `value 
=> 1`
@lcharette
Copy link
Member

I've merged this, and along with #1038, made other improvement in 29bfdd4. Should be good to go now.

@lcharette lcharette removed this from the 4.5.x milestone Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants