Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where all roles are removed from a user #1194

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Handle the case where all roles are removed from a user #1194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/sprinkles/admin/src/Controller/UserController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,11 +1322,15 @@ public function updateField(Request $request, Response $response, array $args)
// Get PUT parameters: value
$put = $request->getParsedBody();

// Make sure data is part of $_PUT data
// Make sure data is part of $_PUT data, default to empty value if sensible, otherwise error
if (isset($put[$fieldName])) {
$fieldData = $put[$fieldName];
} else {
throw new BadRequestException();
if ($fieldName == 'roles') {
$fieldData = [];
} else {
throw new BadRequestException();
}
}

// Create and validate key -> value pair
Expand Down