StrykeSlammerII v420 patch 1 #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At one point I completely tore down my DB and tried rebuilding via migrations, with my own sprinkles in place. Somehow Bakery insisted on running this migration before most of the v400 migrations, so of course this migration errored and Bakery choked. I've added here the relevant dependencies, and Bakery was able to correctly run all my migrations with these changes.
Codecov Report
@@ Coverage Diff @@
## hotfix #1212 +/- ##
=========================================
Coverage 68.45% 68.45%
Complexity 1987 1987
=========================================
Files 169 169
Lines 6685 6685
=========================================
Hits 4576 4576
Misses 2109 2109
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I agree it make way more sense to add those dependencies. |
lcharette
added a commit
to userfrosting/sprinkle-account
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point I completely tore down my DB and tried rebuilding via migrations, with my own sprinkles in place. Somehow Bakery insisted on running the v420/AddingForeignKeys migration before most of the v400 migrations, so of course it errored and Bakery choked. I've added here the relevant dependencies, and Bakery was able to correctly run all my migrations with these changes.