Integrating upstream Whoops issue 752/PR 751 #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Integration test WhoopsRendererTest::testRenderWhoopsPage() and related issues with the Whoops error handler. See related upstream issue filp/whoops#752 and associated PR filp/whoops#751 . Creating a new Run instance here, as I can't find an existing one in UF's WhoopsRenderer. Please point out if I'm just missing it!
|
This fix feels like a hack to me--it works, but I don't know why a new object is required. If there's an existing Whoops\RunInterface, we should use that instead. |
|
It is a hack, but I'm confortable with this fix. FYI, a permanent solution is already implemented in V5 (it use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Integration test WhoopsRendererTest::testRenderWhoopsPage() and related issues with the Whoops error handler. Creating a new Run instance here, as I can't find an existing one in UF's WhoopsRenderer.
(See related upstream issue filp/whoops#752 and associated PR filp/whoops#751)
(See also UF_ConfigManager issue lcharette/UF_ConfigManager#8 (comment))