-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rowDelete event event fix #873
Conversation
The rowDelete event from the ufCollection widget didn't include the deleted row. But following the docs it should: https://learn.userfrosting.com/client-side-code/components/collections#deleterow
(That Travis error looks like a false negative...) |
I restarted the Travis build and everything looks fine now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does passing the row
object as a parameter to trigger
actually work? Everything I'm reading suggests that you need to wrap it in an array.
It does work. Not sure if it should however. The other callbacks also just
take the `row`.
Alex Weissman <notifications@github.com> schrieb am So., 13. Mai 2018,
23:32:
… ***@***.**** commented on this pull request.
Does passing the row object as a parameter to trigger actually work?
Everything I'm reading suggests that you need to wrap it in an array
<https://learn.jquery.com/events/introduction-to-custom-events/#recap-on-and-trigger>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#873 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP3KqgFMzC19gdFObT6E20mM_ODPH7BDks5tyKZ8gaJpZM4TC3as>
.
|
I don't understand...could you explain? |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok! In that case, we will take the more conservative approach and use your code as is.
Released in 4.1.18. |
The rowDelete event from the ufCollection widget didn't include the deleted row.
But following the docs it should: https://learn.userfrosting.com/client-side-code/components/collections#deleterow