Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rowDelete event event fix #873

Closed
wants to merge 1 commit into from
Closed

Conversation

Ekwav
Copy link
Contributor

@Ekwav Ekwav commented Apr 1, 2018

The rowDelete event from the ufCollection widget didn't include the deleted row.
But following the docs it should: https://learn.userfrosting.com/client-side-code/components/collections#deleterow

The rowDelete event from the ufCollection widget didn't include the deleted row.
But following the docs it should: https://learn.userfrosting.com/client-side-code/components/collections#deleterow
@lcharette
Copy link
Member

(That Travis error looks like a false negative...)

@splitt3r
Copy link
Contributor

splitt3r commented Apr 5, 2018

I restarted the Travis build and everything looks fine now 👍

@lcharette lcharette requested a review from alexweissman April 5, 2018 14:53
@lcharette lcharette added the confirmed bug Something isn't working label Apr 5, 2018
@lcharette lcharette added this to the 4.1.17 milestone Apr 5, 2018
Copy link
Member

@alexweissman alexweissman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does passing the row object as a parameter to trigger actually work? Everything I'm reading suggests that you need to wrap it in an array.

@Ekwav
Copy link
Contributor Author

Ekwav commented May 13, 2018 via email

@alexweissman
Copy link
Member

Not sure if it should however. The other callbacks also just take the row

I don't understand...could you explain?

@Ekwav
Copy link
Contributor Author

Ekwav commented May 14, 2018

The row variable is passed to the events rowTouch.ufCollection and rowAdd.ufCollection as well. https://github.com/Ekwav/UserFrosting/blob/0987216fb35feb8eb6a414a3a07e40542b1ec080/app/sprinkles/core/assets/userfrosting/js/uf-collection.js#L261

Copy link
Member

@alexweissman alexweissman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok! In that case, we will take the more conservative approach and use your code as is.

@alexweissman
Copy link
Member

Released in 4.1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants