Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

100% code coverage #5

Closed
Silic0nS0ldier opened this issue Jan 15, 2019 · 2 comments
Closed

100% code coverage #5

Silic0nS0ldier opened this issue Jan 15, 2019 · 2 comments
Assignees
@Silic0nS0ldier

Comments

@Silic0nS0ldier
Copy link
Member

Very close to the magic 100% code coverage on this repo, and codecov.io shows that the untested code is mainly for fail cases (some of which will be removed by updating to PHP v7 for the scalar types).
@Silic0nS0ldier Silic0nS0ldier self-assigned this Mar 17, 2019
Silic0nS0ldier added a commit that referenced this issue Mar 17, 2019
@Silic0nS0ldier
Exclude manual type hints from test coverage #5
e45a48b
Silic0nS0ldier added a commit that referenced this issue Mar 17, 2019
@Silic0nS0ldier
#5
f6dcd0e 
- Fix AssetsTest::testGetAbsoluteUrlWithString
- Stabalise returned absolute path
Silic0nS0ldier added a commit that referenced this issue Mar 17, 2019
@Silic0nS0ldier
#5
091315c 
- `realpath` doubles as an existance check
- Removed redundant edge case handler for mime resolution
- Fixed test busted by previous commit
@Silic0nS0ldier
Copy link
Member Author

Special note about https://codecov.io/gh/userfrosting/assets/src/master/src/AssetsTemplatePlugin.php, there is an unreachable code path that was implemented to facilitate later expansion and as such at this point in time cannot reach complete code coverage.

@Silic0nS0ldier
Copy link
Member Author

Actually, the mentioned code can just be removed. The scope of the helper is for bundles exclusively.

Silic0nS0ldier added a commit that referenced this issue Mar 17, 2019
@Silic0nS0ldier
#5
cfa3189 
 - Removed dead code
- Fixed documented type
- Test fall through case in mime resolution
Silic0nS0ldier added a commit that referenced this issue Mar 17, 2019
@Silic0nS0ldier
#5
4686171 
- Removed unnecessary variable
- Covered potential failure case
- Deprecated legacy code in gulp schema loader
- Fixed silent failure in gulp bundle loader
- Add test cases for gulp bundle loading failure scenarios
Silic0nS0ldier added a commit that referenced this issue Apr 6, 2019
@Silic0nS0ldier
#5 Test coverage improvements for GulpBundleAssets_Bundles classes
a2223ee
Silic0nS0ldier added a commit that referenced this issue Apr 6, 2019
@Silic0nS0ldier
#5 Ignore deprecated code route in coverage
67e5e18
Silic0nS0ldier added a commit that referenced this issue Apr 6, 2019
@Silic0nS0ldier
#5 Improve Assets coverage and address potential edge case
29fc9d5
Silic0nS0ldier added a commit that referenced this issue Apr 6, 2019
@Silic0nS0ldier
#5 100% test coverage and related enhacements
513617d 
- Stabalised absolute path returned by `Assets::urlPathToAbsolutePath` and hardened against silent failure.
- Slightly simplified MIME resolution logic.
- Marked usage of `Assets::readSchema` without a respository as the return value.
- Removed various bit of dead code.
- Fixed silent failure in `gulp-bundle-assets` loading support.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Silic0nS0ldier Silic0nS0ldier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Silic0nS0ldier