Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite #6

Closed
Silic0nS0ldier opened this issue Apr 30, 2018 · 4 comments
Closed

Rewrite #6

Silic0nS0ldier opened this issue Apr 30, 2018 · 4 comments
Assignees
Milestone

Comments

@Silic0nS0ldier
Copy link
Member

This library is in tatters. Frankly, I'm surprised it still works. Worse still, it depends on dependencies with security issues. The effort required to fix this without introducing breaking changes faces diminishing returns. As such, all development effort is to be focused on rewriting the package to ensure UserFrosting v4 continues working correctly in the future.

@Silic0nS0ldier
Copy link
Member Author

Aside from road testing via integration with UF 4.2, this is otherwise done. Will keep it open until remaining milestone issues are resolved.

@Silic0nS0ldier Silic0nS0ldier self-assigned this Nov 17, 2018
@Silic0nS0ldier
Copy link
Member Author

Silic0nS0ldier commented Nov 19, 2018

Some issues observed during the integration testing.

  • Files going to unexpected locations (relative to location specified in dest). Far to easy to misuse currently, so this should be improved.
  • LazyPromise is only lazy once, resulting in things being marked as complete way too soon. A fix for this exists, but is yet to be committed.
  • We'll need to provide the option of specifying what the cwd for bundle resources is, since they are all relative paths.
  • Need to be careful around how things are piped. If nesting occurs, things can get weird. A fix for this exists but is yet to be committed.
  • For unit tests, we shouldn't care about the order of returned stream items. Just that they are all there.
  • types attribute in package needs to specify where d.ts files are. This is fixed but not yet committed.
  • There is a bad hasOwnProperty check, in that it was looking at the wrong object. A fix exists but I'd like to get unit tests for this case up ASAP.

@Silic0nS0ldier
Copy link
Member Author

Gulp is more intuitive around moving files than I had initially gave it credit. We don't need to rewrite paths, just use what was originally called "virtual paths" to permit overrides.

@Silic0nS0ldier
Copy link
Member Author

Feature freeze has now gone into effect, and things are looking stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant