Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% Test Coverage #19

Merged
merged 23 commits into from
Feb 10, 2019
Merged

100% Test Coverage #19

merged 23 commits into from
Feb 10, 2019

Conversation

Silic0nS0ldier
Copy link
Member

Trying to bump test coverage up to the magical 100%. This will take time and be tedious however.

@Silic0nS0ldier Silic0nS0ldier added the PR - don't merge Indicates PR should not yet be merged. label Jan 31, 2019
@Silic0nS0ldier Silic0nS0ldier self-assigned this Jan 31, 2019
@codecov
Copy link

codecov bot commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #19 into develop will increase coverage by 36.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #19       +/-   ##
==========================================
+ Coverage    63.82%   100%   +36.17%     
==========================================
  Files            5     10        +5     
  Lines          235    207       -28     
  Branches        48     24       -24     
==========================================
+ Hits           150    207       +57     
+ Misses          66      0       -66     
+ Partials        19      0       -19
Impacted Files Coverage Δ
src/config/merge-bundle.ts 100% <100%> (ø)
src/catcher.ts 100% <100%> (+16.66%) ⬆️
src/main.ts 100% <100%> (+63.44%) ⬆️
src/log-levels.ts 100% <100%> (ø)
src/config/validate-bundle.ts 100% <100%> (ø)
src/config/validate-config.ts 100% <100%> (ø)
src/config/config.ts 100% <100%> (ø)
src/config/merge-configs.ts 100% <100%> (ø)
src/bundles-processor.ts 100% <100%> (+16.66%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a774f...60b6836. Read the comment docs.

Silic0nS0ldier and others added 20 commits January 31, 2019 19:05
@Silic0nS0ldier
#8 Remove unneeded checks (internal class, guarded by design)
2b4c2c3
@Silic0nS0ldier
Run tests on Windows
a1830a6
@Silic0nS0ldier
RIP Windows on Travis support
602adae
@Silic0nS0ldier
#8 More test coverage for bundles-processor
37727e9
@Silic0nS0ldier
#8 Ignore code that only runs by chance of runtime status in catcher
0f2faf5
@Silic0nS0ldier
#8 Test coverage improvements
b489dcf 
- Factored merge logic into multiple files for improved maintainability
- Improve test coverage across multiple components
- Renamed many test names to improve usefulness
@Silic0nS0ldier
#8 Improve merge bundle test coverage
c3b9ef0
@Silic0nS0ldier
#8 Improve test coverage for merge-configs
66f0ab5
@Silic0nS0ldier
Updated changelog and readme
082f60e
@Silic0nS0ldier
#8
2f86a46 
- Improved test coverage of validate config
- Fixed duplicate detection in validate config
- Updated changelog
@Silic0nS0ldier
#8 Last line of validate config (test coverage)
49225a4
@Silic0nS0ldier
#8 Last line for validate bundle (test coverage)
e2985a5
@Silic0nS0ldier
#8
a0edf44 
- Fixed #21
- Improved test coverage of `main.ts`
@Silic0nS0ldier
#8
9d53d61 
- Additional (rough) coverage for main.
- Improved logging ownership.
@Silic0nS0ldier
#21 Only run fix if its needed
41ce86e
@Silic0nS0ldier
- #8 Super rough test improvements for main
ff9cfad 
- #22 Backwards compatible fix for overwriting of results callback data
@Silic0nS0ldier
#22 Updated changelog
da4ef62
@Silic0nS0ldier
Remove redundant double nyc usage and if-env
dcc5460
@Silic0nS0ldier
#8 Improve coverage of main
b27bdf0
@Silic0nS0ldier
#8 Attempt at hitting 100% one
8cfcc4e
@Silic0nS0ldier Silic0nS0ldier removed the PR - don't merge Indicates PR should not yet be merged. label Feb 7, 2019
@Silic0nS0ldier Silic0nS0ldier requested a review from a team February 8, 2019 06:52
@Silic0nS0ldier Silic0nS0ldier merged commit 121a3d8 into develop Feb 10, 2019
@Silic0nS0ldier Silic0nS0ldier deleted the develop-completeTestCoverage branch February 10, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcharette lcharette lcharette approved these changes

Assignees

@Silic0nS0ldier Silic0nS0ldier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silic0nS0ldier @lcharette