-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #1
Refactor #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general, the only improvement we can think about is just using either focus-visible
class or the data-focus-visible-added
data attribute instead of both of them.
@buscape I don't want to change what the original library does because chakra-ui relies on them and may rely on them in a different way in future. |
Refactors the original impl to do the following changes:
enablePonyfill
function.enablePonyfill
returns a cleanup function that undoes ponyfilling (WIP).@userlike/focus-visible
.