Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Add spymemcached system override properties #2

Merged

Conversation

favila
Copy link

@favila favila commented Apr 30, 2021

Adds the following system properties:

  • clubhouse.spymemcached.forceProtocol=TEXT (or BINARY)
  • clubhouse.spymemcached.forceOpTimeoutMs
  • clubhouse.spymemcached.forceOpQueueMaxBlockTimeMs

If any of these are set, they will override the value passed to the corresponding builder method in ConnectionFactoryBuilder. This is for the very specific purpose of forcing datomic to use the ASCII protocol and messing with timeout settings.

Also has some bitrot-fixing commits to get it building again:

  • MemcachedConnection imported some packages from outside the java.base module; fortunately it didn't use them, so I just removed them.
  • The ant build referenced a now-gone maven server. URL was updated.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #156825: Spymemcached lib with protocol override options.

@favila favila requested a review from pgroudas April 30, 2021 22:03
Copy link

@pgroudas pgroudas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants