-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shader renames jansi #1977
shader renames jansi #1977
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
=======================================
Coverage 49% 49%
- Complexity 6261 6272 +11
=======================================
Files 665 665
Lines 59622 59624 +2
Branches 8645 8645
=======================================
+ Hits 29391 29406 +15
+ Misses 28033 28019 -14
- Partials 2198 2199 +1 ☔ View full report in Codecov by Sentry. |
On windows the jar produced cannot be used as a REPL:
most likely due to the native bindings:
|
Ok, I've also had to relocate Now it seems to work on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the config to work on Windows.
This PR uses the shader to move the
org.fusesource.jansi
package toorg.rascalmpl.fusesource.jansi
. Doing this prevents a later collision between jansi versions inside of the mvn runtime.Some collatoral fix: For
-B
mvn batch mode the monitor did not print intermediate steps anymore. Fixed that too.