Data type not validated in custom form fields

[srutto]

Steps to reproduce:

1. Login to the admin panel
2. Go to Manage/Forms which will take you to the forms page. Click on Edit Form Fields -> http://i.imgur.com/H7emp.png
3. Add a new field. Enter the field details and select the data type of the field, eg Numeric, and save
4. Go to Submit a Report page and create a report. Enter the data in the new field that was created as free text

Expected Result:

An error message should be thrown that only numeric data type is expected for the field.

Actual Result:

Report is saved. No error thrown.

Tested on version 2.5. Tested with the other data types and got the same results. The values submitted in the custom field are not validate. All data types entered by the user is submitted regardless of the data type set in the admin end.

[rjmackay]

@srutto Theres nowhere near enough if here to debug. Can you clean up this bug report?
A good report should have:

• steps to reproduce the issues
• Expected result
• actual result
• Version of the software you were testing on
• Screen shots if appropriate

See https://developer.mozilla.org/en-US/docs/Bug_writing_guidelines for some more details on how to write a good bug report.

[PoPoutdoor]

I think this is about custom form fields.

[rjmackay]

@srutto thanks for the update description.. much better!

[manwinder]

@aoduor @elle-espere

My deployment address is https://indiaoye.crowdmap.com/
I have added a mobile field to the submit report form, selected a numeric field (10 digits) and marked it as 'Required'
However no validation applies - I could submit a report with blank mobile no., with alphanumeric data and with more than 10 digits.

Request you to add my report to the above repository.

[aoduor]

@manwinder working on a fix for this. As I had earlier mentioned, this fix will be available once the next version of Ushahidi is released, on April 30th. It will then be made available on crowdmap thereafter.

[manwinder]

@aoduor - wanted to bring the following to your notice too (Crowdmap)

I have added 'Mobile No.' as an additional field in the 'Submit Report' page.
However, the field does not appear some times - at other time, one can see it.

The appearing of the field is very random - hope this is in your notice and will get resolved in the new version.

[rjmackay]

@manwinder that sounds like the permissions (who can edit, who can view) on the mobile field might be set incorrectly. Does it appear differently when your logged in/logged out?

[manwinder]

@rjmackay I am aware about the feature to set permissions. But here I am referring to the 'Field' itself. As mentioned earlier I have added 'Mobile Field' (Screen shot of settings attached).
But when I 'Submit Report', the 'Mobile Field' itself does not appear sometimes. This time it did appear luckily (screen shot attached'. But I'll send you a screen shot when I am able to reproduce the issue.

[manwinder]

@rjmackay Here is the screen shot of the report page where the Mobile field is not visible despite of not changing any settings.

[rjmackay]

@manwinder this is really just issue #744 and should be fixed soon.

[manwinder]

@rjmackay @elleespere Alright - though I couldn't understand #744 completely, but yes I realize the problem may be with Login. My settings of the private field are
Who Can Report - Anyone
Who can view - Sadmin

My understanding of the above setting is that anyone should be able to submit the mobile number, thus 'Mobile No. Fiedl' should be visible to all at 'Submit Report' page, irrespective of the login.
After a report has been, the mobile numbers of the reporters should not be visible to everyone (confidentiality reasons). But should be visible only to the designated few(admin/ Sadmin) for verification etc.

Kindly let me know, if my understanding is correct and if after the fix, this functionality would work as per my understanding / requirement ?

[rjmackay]

You're understanding is correct. This should work once 2.7 is released

[ghost]

Thanks @rjmackay =)

[rjmackay]

@manwinder please post that issue to the Ushahidi Android repo