Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve / optimize reports listing view #857

Closed
rjmackay opened this issue Sep 30, 2012 · 0 comments
Closed

Improve / optimize reports listing view #857

rjmackay opened this issue Sep 30, 2012 · 0 comments
Milestone
Ushahidi v2.6

Comments

@rjmackay
Copy link
Contributor

Currently the reports listing view is messy and inefficient. Merge in a few improvements from custom deployments

  • Don't reload incidents with the ORM
  • Use url::site() properly.. ie
    url::site('reports') not url::site().'reports'
  • Allow plugins to extend the filter JS.. not just the filters themselves
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Oct 1, 2012
@rjmackay
Don't reload incidents with ORM in reports listing view ushahidi#857
79494e0 
Removes about 1 query per report listed, and makes it easier to mess
with the reports passed to the listing
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Oct 1, 2012
@rjmackay
Better use of url::site() in views/reports/list.php ushahidi#857
78972ba 
Use uri parameter of url::site() rather than manually joining strings
this improves readability of the code
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Oct 1, 2012
@rjmackay
Add helper methods for getting incident URLS ushahidi#857 ushahidi#853
cb39fea 
These are used in the json controller and reports listing
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Oct 1, 2012
@rjmackay
Add event to reports/reports_js view to allow adding extra filters us…
0123461 
…hahidi#857

Adds event: ushahidi_action.report_js_filterReportsAction
rjmackay added a commit to rjmackay/Ushahidi_Web that referenced this issue Oct 1, 2012
@rjmackay
Fix incident url helper and use it in reports/list view ushahidi#857
abf1c5f
@rjmackay rjmackay closed this as completed Oct 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ushahidi v2.6
Development

No branches or pull requests
1 participant
@rjmackay