Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default country is added to location in /admin/reports even on multicountry deployments #880

Closed
rjmackay opened this issue Oct 10, 2012 · 2 comments

Comments

@rjmackay
Copy link
Contributor

Matching https://github.com/ushahidi/Crowdmap/issues/144

Steps to reproduce the issues

  1. add report
  2. add location details (address (numbered street and city)
  3. click find location
  4. modify location in location box to include bar or venue name
  5. click save

Map default country was kenya, because it is a global map.

Expected result

Actual location would appear

Actual observed result

actual location plus "KENYA" appears

Details of your environment

Version of Ushahidi you were testing on
Crowdmap
Browser you were testing in
Firefox
Operating system you were testing on
OSXXX

Deployment you were testing (including URL if publicly available)

Iccm12.crowdmap.com

Screen shots if appropriate
http://cl.ly/image/0A0k273B1y1B 2.http://cl.ly/image/3j090i210Q1n
http://cl.ly/image/2h0M0L2E1543 ( added the location to find location. clicked find. It did.
http://cl.ly/image/3R2U2z3Q291N fixed
I had to do this for 8 reports in this. See the edit logs.

Update: I want this map to span multiple countries. Given that most of the locations are based in DC. I've changed the map center to DC and the country default to USA.

However, if I have a global map, I should not have the default country fill in if the city and state were added. It should smart search the matching location

@aoduor
Copy link
Member

aoduor commented Oct 10, 2012

Looks like the issue here is that the geolocator is not working. The only point at which the default country name is appended is if there is no country id that was saved along with the location during report Submission.

Angela

Handheld sent

----- Reply message -----
From: "Robbie MacKay" notifications@github.com
To: "ushahidi/Ushahidi_Web" Ushahidi_Web@noreply.github.com
Subject: [Ushahidi_Web] Default country is added to location in /admin/reports even on multicountry deployments (#880)
Date: Wed, Oct 10, 2012 04:00
Matching ushahidi/Crowdmap#144

Steps to reproduce the issues

  1. add report
  2. add location details (address (numbered street and city)
  3. click find location
  4. modify location in location box to include bar or venue name
  5. click save

Map default country was kenya, because it is a global map.

Expected result

Actual location would appear

Actual observed result

actual location plus "KENYA" appears

Details of your environment

Version of Ushahidi you were testing on

Crowdmap

Browser you were testing in

Firefox

Operating system you were testing on

OSXXX

Deployment you were testing (including URL if publicly available)

Iccm12.crowdmap.com

Screen shots if appropriate
http://cl.ly/image/0A0k273B1y1B 2.http://cl.ly/image/3j090i210Q1n
http://cl.ly/image/2h0M0L2E1543 ( added the location to find location. clicked find. It did.
http://cl.ly/image/3R2U2z3Q291N fixed

I had to do this for 8 reports in this. See the edit logs.

Update: I want this map to span multiple countries. Given that most of the locations are based in DC. I've changed the map center to DC and the country default to USA.

However, if I have a global map, I should not have the default country fill in if the city and state were added. It should smart search the matching location

Reply to this email directly or view it on GitHub.

@aoduor
Copy link
Member

aoduor commented Oct 10, 2012

Small typo, meant to refer to country_id and reverse geolocator

----- Reply message -----
From: "Robbie MacKay" notifications@github.com
To: "ushahidi/Ushahidi_Web" Ushahidi_Web@noreply.github.com
Subject: [Ushahidi_Web] Default country is added to location in /admin/reports even on multicountry deployments (#880)
Date: Wed, Oct 10, 2012 04:00
Matching ushahidi/Crowdmap#144

Steps to reproduce the issues

  1. add report
  2. add location details (address (numbered street and city)
  3. click find location
  4. modify location in location box to include bar or venue name
  5. click save

Map default country was kenya, because it is a global map.

Expected result

Actual location would appear

Actual observed result

actual location plus "KENYA" appears

Details of your environment

Version of Ushahidi you were testing on

Crowdmap

Browser you were testing in

Firefox

Operating system you were testing on

OSXXX

Deployment you were testing (including URL if publicly available)

Iccm12.crowdmap.com

Screen shots if appropriate
http://cl.ly/image/0A0k273B1y1B 2.http://cl.ly/image/3j090i210Q1n
http://cl.ly/image/2h0M0L2E1543 ( added the location to find location. clicked find. It did.
http://cl.ly/image/3R2U2z3Q291N fixed

I had to do this for 8 reports in this. See the edit logs.

Update: I want this map to span multiple countries. Given that most of the locations are based in DC. I've changed the map center to DC and the country default to USA.

However, if I have a global map, I should not have the default country fill in if the city and state were added. It should smart search the matching location

Reply to this email directly or view it on GitHub.

@rjmackay rjmackay reopened this Oct 15, 2012
rjmackay added a commit that referenced this issue Oct 19, 2012
Country was being appended even on multi country deployments.
This isn't appended in the frontend so I've removed it from the backend
entirely for consistency and simplicity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants