Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a pre-existing incident as a member creates a duplicate incident #897

Closed
jetherton opened this issue Oct 22, 2012 · 2 comments
Closed

Editing a pre-existing incident as a member creates a duplicate incident #897

jetherton opened this issue Oct 22, 2012 · 2 comments
Assignees
@jetherton
Labels
Bug P1 - Immediate

Comments

@jetherton
Copy link
Collaborator

  1. Log in as a member
  2. go to /members/reports/edit/N
  3. make some changes
  4. click save

then look at /members/reports and you'll notice that there are now too incidents that are exactly the same, except for the changes made in step 3.
@ghost ghost assigned jetherton Oct 22, 2012
jetherton added a commit that referenced this issue Oct 22, 2012
@jetherton
Closes issue #897 - Editing a pre-existing incident as a member creat…
0393870 
…es a duplicate incident

I know it doesn't look like much, but that little "$id" is pretty darn important.
@jetherton
Copy link
Collaborator Author

So it seems a loan $id was missing from a function. It's always those small, helpless variables that fall through the cracks.

@rjmackay
Copy link
Contributor

Yikes. Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jetherton jetherton

Labels
Bug P1 - Immediate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjmackay @jetherton