Datepicker issues in default theme. #1126
Conversation
- Don't use mm/dd/yyyy format as this will be parsed inconsistently by PHP's strtotime() depending on locale settings. Use ISO date format instead. - Make sure the "This Week" quicklink works even if the week crosses into the following month.
|
Is this impacted at all by the browsers locale too? |
|
I don't think so - the following line: date = $.datepicker.parseDate( instance.settings.dateFormat || $.datepicker._defaults.dateFormat )... uses datepicker's default format which is also mm/dd/yyyy (so there is no client-side localisation). The only issue is that PHP will not parse this format consistently. |
|
Merging this in. |
Datepicker issues in default theme.
|
Also note: this should fix other themes too since they don't override reports_js they just inherit it. |
|
Hmm there are still some issues here. Apparently the Also if you select "all time" then the title displays: "Showing Reports From to". Also the format displayed in the title changes when you select a date range. Neither affects functionality but they do look a bit weird. |
Ran into a few issues with the datepicker in the reports view of the default theme. It uses the US standard date format (mm/dd/yyyy), and if the PHP locale is different, then the date query will be parsed differently by the server (e.g., 01/05/2013 will be parsed as 1st May 2013 and not 5th January 2013).
Also the "this week" quicklink breaks when the week crosses into the next month.
I haven't looked at the other bundled themes, but this may apply to them as well?