Use overpass for cities list #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ushahidi#979 isses with geonames timing out for large countries. Now using a overpass API query against current OSM data, this also means we're no longer using a dodgy bounding box to find cities, but actually only getting cities within a country boundary.
This was referenced Jan 14, 2013
kamaulynder
added a commit
that referenced
this pull request
Feb 1, 2013
Use overpass for cities list
|
Fixed |
|
Question, I am using version 2.6.1 and I still have this problem. Do I need to update my code? |
|
@kamangir This code is currently only in the development version. This will be released in version 2.7 |
|
Thank you for the reply. Any release date scheduled? @rjmackay |
|
Release should be end of april or soon after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979 isses with geonames timing out for large countries.
Uses OSM overpass API query instead of Geonames. This also means
we're no longer using a dodgy bounding box to find cities, but actually
only getting cities within a country boundary.