Veracity integration and Yodie+Crees bugfixing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowasc
changed the base branch from
master
to
sheffield-service-integration
rowasc
commented
Sep 24, 2018
app/Jobs/RunVeracityService.php
Outdated
| { | ||
| $tags = []; | ||
| $json = json_decode($response->getBody(), true); | ||
| switch($json['rumour_label']) { |
There was a problem hiding this comment.
eh so this is really gross but since we don't receive the names we want to use for categories, I had to map the
rumor_label : true => Rumor
rumor_label : false => Not a rumor
rumor_label : 'unverified' => 'Unverified'
I think maybe a cleaner approach might be to "stringify" the rumour_label to ensure we can just do a map and return ir ['false' => "Not a rumor" , 'true' => "Rumor" , 'unverified' => "Unverified"]
rowasc
commented
Sep 24, 2018
|
|
||
|
|
||
|
|
||
| VERACITY_API_URL=<full_url_of_actionability_api> |
There was a problem hiding this comment.
oops change to <full_url_of_veracity_api> for clarity
…s with categories, including Veracity scores or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note -
after this PR is approved, I'll send another one with sheffield-service-integration to master since I was working off this branch and sheffield-service-integration was already reviewed by Will