Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ush 1190 - Meaningful error messages on mobile around offline posts being uploaded #1152

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Ush 1190 - Meaningful error messages on mobile around offline posts being uploaded #1152

merged 2 commits into from
Jul 8, 2024

Conversation

ushahidlee
Copy link
Contributor

Issue:

When a user creates a post in offline mode, the platform displays a success message indicating the post has been created.However, upon regaining an internet connection, the platform displays a toast error message..

Changes:

This PR changes the error messages around offline posts being uploaded to be meaningful to users. It also removes a few redundant calls to the API, when the app is aware there is no network, that was causing excessive error messages.

Testing:

  1. Open the mobile app and activate airplane mode (or disable wifi/mobile data) to simulate offline mode.
  2. Start creating a new survey post and fill out all the required information.
  3. Submit the completed survey post.
  4. Observe the success message displayed by the platform indicating the post creation.
  5. Deactivate airplane mode (or reconnect to wifi/mobile data) to regain internet connection.
  6. Wait a few moments for the app to attempt syncing offline data.
  7. Look for a toast error message appearing on the screen mentioning the upload failure.
  8. confirm the post is created using other device

@ushahidlee ushahidlee requested a review from Angamanga July 4, 2024 13:27
@linear Linear
Copy link

linear bot commented Jul 4, 2024

USH-1190 Incorrect success message for creating an offline post

Angamanga
Angamanga approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. Note though: I only tested in the simulator, not on an actual device, but it seems to be working fine!

@ushahidlee ushahidlee merged commit 64e1dcb into development Jul 8, 2024
10 of 12 checks passed
AmTryingMyBest pushed a commit that referenced this pull request Jul 15, 2024
@ushahidlee @AmTryingMyBest
Ush 1190 - Meaningful error messages on mobile around offline posts b…
c901198 
…eing uploaded (#1152)

* commit
AmTryingMyBest added a commit that referenced this pull request Jul 15, 2024
@AmTryingMyBest @Angamanga
@ushahidlee @Ifycode
add steps to delete category - through bulk actions (#1157)
170b047 
* add steps to delete category - through bulk actions

* update categories to match CI categories

* add missing step

* update tests for CI

* update and rerun tests

* update and rerun tests

* rerun tests

* separate delete child and parent category tests into separate functions

* update child test deleted

* rerun tests

* change child category getting deleted

* change child category getting deleted

* adjust id to verify child category

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* add tests for deleting category from category details page

* update test

* update url verifying path

* change parent category getting deleted

* rerun tests

* rerun tests

* update child category verification

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* Add other-option when configuring a survey (#1128)

* Add other-option when configuring a survey

* Removing other-option from dropdown

* Removing forgotten mistake

* Ush 1190 - Meaningful error messages on mobile around offline posts being uploaded (#1152)

* commit

* Made some cheeky changes (#1155)

* Fix: Adding of post to collection submit & checked state (#1133)

Co-authored-by: Anna Iosif <anna.iosif@me.com>

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

---------

Co-authored-by: Anna Iosif <anna.iosif@me.com>
Co-authored-by: ushahidlee <152860706+ushahidlee@users.noreply.github.com>
Co-authored-by: Mary @Ifycode <marychord@gmail.com>
tuxpiper pushed a commit that referenced this pull request Aug 8, 2024
@ushahidlee @tuxpiper
Ush 1190 - Meaningful error messages on mobile around offline posts b…
92028f4 
…eing uploaded (#1152)

* commit
tuxpiper pushed a commit that referenced this pull request Aug 8, 2024
@AmTryingMyBest @Angamanga
@ushahidlee @Ifycode @tuxpiper
add steps to delete category - through bulk actions (#1157)
13c10ab 
* add steps to delete category - through bulk actions

* update categories to match CI categories

* add missing step

* update tests for CI

* update and rerun tests

* update and rerun tests

* rerun tests

* separate delete child and parent category tests into separate functions

* update child test deleted

* rerun tests

* change child category getting deleted

* change child category getting deleted

* adjust id to verify child category

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* add tests for deleting category from category details page

* update test

* update url verifying path

* change parent category getting deleted

* rerun tests

* rerun tests

* update child category verification

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* Add other-option when configuring a survey (#1128)

* Add other-option when configuring a survey

* Removing other-option from dropdown

* Removing forgotten mistake

* Ush 1190 - Meaningful error messages on mobile around offline posts being uploaded (#1152)

* commit

* Made some cheeky changes (#1155)

* Fix: Adding of post to collection submit & checked state (#1133)

Co-authored-by: Anna Iosif <anna.iosif@me.com>

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

* rerun tests

---------

Co-authored-by: Anna Iosif <anna.iosif@me.com>
Co-authored-by: ushahidlee <152860706+ushahidlee@users.noreply.github.com>
Co-authored-by: Mary @Ifycode <marychord@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angamanga Angamanga Angamanga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ushahidlee @Angamanga