fix: Sanitize raven breadcrumbs too #1193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Testing checklist:
Configure your client deployment in config.js with
ravenUrl: 'https://407e538550a64857ac099f98ac8cceef@sentry.io/88046'
Open the client
Move around the UI and generate errors (data view has a few noisey errors)
Log in as a normal user (not admin)
Move around the UI and generate errors (data view has a few noisey errors)
Check Sentry errors in dashboard now show your user id
Log out
Trigger errors on the client and watch for sentry HTTP requests
Check Sentry errors in dashboard no longer show your user id
Check data sent to sentry.io in network tab does not contain sensitive info
Check Sentry dashboard and confirm logged errors do not contain sensitive info
I certify that I ran my checklist
Refs ushahidi/platform#1596
Ping @ushahidi/platform