Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the deployment to heroku #1779

Closed
wants to merge 1 commit into from
Closed

Conversation

ps-19
Copy link

@ps-19 ps-19 commented Apr 13, 2022

This pull request makes the following changes:
After brain storming for many hours on heroku and repo i got the silly reason for the issue.

Testing checklist:

  • I have tested the build.

  • I certify that I ran my checklist

Fixes ushahidi/platform#4288.

Ping @ushahidi/platform

@Angamanga
Copy link
Collaborator

@tuxpiper Could you review this? 🙏

@Angamanga Angamanga requested a review from tuxpiper May 5, 2022 10:45
@tuxpiper
Copy link
Member

tuxpiper commented May 5, 2022

I think that's fine, but since it's the develop branch, a disclaimer should be added that the deployed site may not work or be usable (unstable version).

Otherwise, it should point to the "main" branch instead.

Could you please adjust @ps-19 ?

Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

@ps-19
Copy link
Author

ps-19 commented May 6, 2022

@tuxpiper sir where should i add the disclaimer, in the readme.md file.

And even if it is pointing towards main still "No app.json located in the repo URL provided" is showing it should point to developer branch to successfully deploy on heroku i have tested both.

@tuxpiper
Copy link
Member

Oh I see, so it looks like we are actually missing more bits here in order to make this PR viable..

@Angamanga do you recall if we had that app.json before and was removed as part of the Single-SPA changes?

@tuxpiper tuxpiper requested a review from Angamanga May 17, 2022 08:56
@tuxpiper
Copy link
Member

I think that without that missing app.json file, we should close this PR. Anyone willing to spend a few minutes, I'm pretty sure they can fish that out from previous commits.

@tuxpiper tuxpiper closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants