Fix timezone issues with post date #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd910d6.
- Vastly simplify post-datetime-value directive - Only save when date/time picker closes - Just let datepicker handle setting the model
|
@jshorland assuming the auto deploy works you should be able to test this before it lands.. the link should appear above in the timeline. ... http://qa.fix-date-timezone-issues.ushahidilab.com/ |
willdoran
approved these changes
Nov 9, 2016
| @@ -18,6 +18,21 @@ module.exports = ['PostEndpoint', function (PostEndpoint) { | |||
| return PostEndpoint.get({ id : entry }); | |||
| }); | |||
| } | |||
| if ($scope.attribute.type === 'datetime' && $scope.attribute.input === 'date') { | |||
There was a problem hiding this comment.
Could this be a single outer if($scope.attribute.type==='datetime')
And then split out ifs beneath it, I'm not sure if that would be clearer
rjmackay
force-pushed
the
fix-date-timezone-issues
branch
from
06ccab6 to
b79f427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test these changes by:
Fixes ushahidi/platform#1362
Ping @ushahidi/platform
This change is