Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling when logging in and out #408

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Better handling when logging in and out #408

merged 1 commit into from
Nov 8, 2016

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Nov 8, 2016 •
edited
Loading

  • Stay on current page when logging in
  • If access is denied, try to redirect back after login
  • Stay on current page for log out, but reload

This change is Reviewable

@rjmackay rjmackay temporarily deployed to ushahidi-platform-devel-pr-408 November 8, 2016 00:44 Inactive
@coveralls
Copy link

coveralls commented Nov 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 51.221% when pulling 804a328 on hotfix/login-behaviour into debf4aa on master.

@rjmackay rjmackay assigned rjmackay and unassigned jshorland Nov 8, 2016
@rjmackay
Better handling when logging in and out
635c336 
- Stay on current page when logging in
- If access is denied, try to redirect back after login
- Stay on current page for log out, but reload
@rjmackay rjmackay force-pushed the hotfix/login-behaviour branch from 804a328 to 635c336 Compare November 8, 2016 02:54
@rjmackay rjmackay temporarily deployed to ushahidi-platform-devel-pr-408 November 8, 2016 02:54 Inactive
@coveralls
Copy link

coveralls commented Nov 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 51.649% when pulling 635c336 on hotfix/login-behaviour into 76c7d73 on master.

@ushbot ushbot temporarily deployed to rackspace_pr November 8, 2016 03:01 Inactive
@rjmackay rjmackay force-pushed the hotfix/login-behaviour branch from 635c336 to 8b7258e Compare November 8, 2016 03:05
@rjmackay rjmackay temporarily deployed to ushahidi-platform-devel-pr-408 November 8, 2016 03:05 Inactive
@coveralls
Copy link

coveralls commented Nov 8, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 51.853% when pulling 8b7258e on hotfix/login-behaviour into 76c7d73 on master.

@ushbot ushbot temporarily deployed to rackspace_pr November 8, 2016 03:12 Inactive
@rjmackay rjmackay force-pushed the hotfix/login-behaviour branch from 8b7258e to 635c336 Compare November 8, 2016 03:14
@ushbot ushbot temporarily deployed to rackspace_pr November 8, 2016 03:21 Inactive
@jshorland
Copy link

Passes qa.

@rjmackay rjmackay merged commit c95f021 into master Nov 8, 2016
@tuxpiper tuxpiper deleted the hotfix/login-behaviour branch August 19, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rjmackay rjmackay

@jshorland jshorland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjmackay @coveralls @jshorland @ushbot