Changing Post/Survey Title Description fields to be editable #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmackay
previously requested changes
Nov 11, 2016
| @@ -113,11 +116,17 @@ function PostEditorController( | |||
| // If attributesToIgnore is set, remove those attributes from set of fields to display | |||
| var attributes = []; | |||
| _.each(attrs, function (attr) { | |||
| if (!_.contains($scope.attributesToIgnore, attr.key)) { | |||
| if (attr.type === 'title' || attr.type === 'description') { | |||
There was a problem hiding this comment.
Do we really need this first if?
There was a problem hiding this comment.
I think probably not, I'm not sure what it was for
| @@ -113,11 +116,17 @@ function PostEditorController( | |||
| // If attributesToIgnore is set, remove those attributes from set of fields to display | |||
| var attributes = []; | |||
| _.each(attrs, function (attr) { | |||
| if (!_.contains($scope.attributesToIgnore, attr.key)) { | |||
| if (attr.type === 'title' || attr.type === 'description') { | |||
| if (attr.type === 'title') { | |||
There was a problem hiding this comment.
It might be cleaner (though less efficient) to just do
_.findWhere(attrs, {type: 'title}) and then process that.. rather than adding many conditions to a loop
| <label translate="survey.require_field">Require this field be completed</label> | ||
| <div class="toggle-switch"> | ||
| <input class="tgl" id="switchnewattribute" type="checkbox" ng-model="editAttribute.required"> | ||
| <label class="tgl-btn" for="switchnewattribute"></label> | ||
| </div> | ||
| </div> | ||
| <div class="form-sheet" ng-show="editAttribute.form_stage_id"> | ||
| <div class="form-sheet" ng-show="editAttribute.form_stage_id" ng-show="editAttribute.type !== 'title' && editAttribute.type !== 'description'"> |
There was a problem hiding this comment.
Multiple ng-show's won't work here.
| @@ -3,7 +3,7 @@ | |||
| <label translate="app.name">Name</label> | |||
| <input type="text" ng-model="editAttribute.label"> | |||
| </div> | |||
| <div class="form-field" ng-if="editAttribute.input !== 'upload'"> | |||
| <div class="form-field" ng-if="editAttribute.input !== 'upload' && editAttribute.type !== 'title' && editAttribute.type !== 'description'"> | |||
There was a problem hiding this comment.
This is kinda ugly.. could we move this to a canSetDefault method on the scope?
There was a problem hiding this comment.
Actually given the 3 new checks.. it seems like you could just wrap all the the form after label in 1 large ng-if and it'd be cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test these changes by:
Fixes ushahidi/platform#1469
Ping @ushahidi/platform
This change is