Don't allow making tags attributes private

ushahidi · May 19, 2017 · e09837e · e09837e
1 parent 43fdc31
commit e09837e
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/application/classes/Ushahidi/Validator/Form/Attribute/Update.php b/application/classes/Ushahidi/Validator/Form/Attribute/Update.php
@@ -29,6 +29,8 @@ public function __construct(FormAttributeRepository $repo, FormStageRepository $
 
     protected function getRules()
     {
+        $input = $this->validation_engine->getFullData('tags');
+
         return [
             'key' => [
                 ['max_length', [':value', 150]],
@@ -76,7 +78,7 @@ protected function getRules()
                 ]]],
             ],
             'required' => [
-                ['in_array', [':value', [true,false]]],
+                ['in_array', [':value', [true, false]]],
             ],
             'priority' => [
                 ['digit'],
@@ -92,10 +94,13 @@ protected function getRules()
             'form_id' => [
                 ['digit'],
             ],
+            'response_private' => [
+                [[$this, 'canMakePrivate'], [':value', $input]]
+            ]
         ];
     }
 
-     public function formStageBelongsToForm($value)
+    public function formStageBelongsToForm($value)
     {
         // don't check against nonexistant data
         if (!$value || !isset($this->valid['form_id'])) {
@@ -105,4 +110,14 @@ public function formStageBelongsToForm($value)
         $group = $this->form_stage_repo->get($value);
         return ($group->form_id == $this->valid['form_id']);
     }
+
+    public function canMakePrivate($value, $input)
+    {
+        // If input type is tags, then attribute cannot be private
+        if ($input === 'tags' && $value !== false) {
+            return false;
+        }
+
+        return true;
+    }
 }