Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Distinguish between post fields and task fields #1283

Closed
6 of 8 tasks
rjmackay opened this issue Jul 4, 2016 · 4 comments
Closed
6 of 8 tasks

Feature: Distinguish between post fields and task fields #1283

rjmackay opened this issue Jul 4, 2016 · 4 comments
Assignees
Milestone

Comments

@rjmackay
Copy link
Contributor

rjmackay commented Jul 4, 2016

Changes

  • API: Mark "Post" stage as special (maybe type: post vs type: task)
    • Post stage doesn't have complete/not completed
  • API: Add description and visibility for stages
  • Split post fields and task fields in survey settings
  • Split post fields and task fields in post edit
  • Split post fields and task field in post detail
  • Remove 'completed' toggle from "Post"
  • API: Add is_public field to post stages
  • Add "Show this task to everyone when the post is published" to task settings
  • Out of scope: Add display logic for "Show this task to everyone when the post is published"
  • Out of scope: "ASSIGN THIS TASK TO..." dropdown

Background:
https://github.com/ushahidi/platform-client/issues/149#issuecomment-228809927
#1262 (comment)
#1263 (comment)
#1237 (comment)
#1237 (comment)
https://github.com/ushahidi/platform-client/issues/147


@willdoran
Copy link
Contributor

willdoran commented Aug 16, 2016

Test these changes by on ushahidev:

  • Survey Edit
  • Add Post fields
  • Add Tasks
  • Add fields to Task
  • Set "Require this task be completed before a post can be visible to the public"
  • Save survey
  • Post Edit/Detail
  • Create Post from Survey with No Tasks - tasks tabs should not be displayed
  • Create Post from Survey with Tasks - task tabs should be displayed
  • Save Post with title and description only - task tabs should not be displayed in Post Detail
  • Edit Post, add values to Task fields - task tabs and values should be displayed in Post Detail
  • Edit Post, with Task where "Require this task be completed before a post can be visible to the public", do not mark Task completed, attempt to save

@jshorland
Copy link

jshorland commented Aug 27, 2016

  • Add posts fields has a small design flaw. I'm going to pass the adding of fields, and have opened Radio buttons should be to the left of text, same as checkboxes #1353
  • Create post from survey with tasks (tasks show): Failed. I can add the tasks in the survey edit mode, but when I add a post to the survey and save, it takes me to a screen that for some reason only shows the first and last task. I tried typing a really long task name to see what happened, but it looks like there's a scroll bar on tasks, so I don't think that would be the cause. Screenshot attached. However, when I completed the tasks in edit mode and returned to the post detail mode, I saw all of them.
    screen shot 2016-08-26 at 6 21 45 pm

@jshorland
Copy link

Its now working for me. All pass QA

@rjmackay rjmackay reopened this Sep 2, 2016
@rjmackay
Copy link
Contributor Author

rjmackay commented Sep 2, 2016

@willdoran was is_public and "Show this task to everyone when the post is published" implemented as part of this? I know we talked about splitting this while at team meeting. However if we haven't captured that task somewhere else this issue shouldn't be closed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants