1283 survey edit update #301

willdoran · 2016-08-03T23:20:13Z

This pull request makes the following changes:

API: Mark "Post" stage as special (maybe type: post vs type: task)
- Post stage doesn't have complete/not completed
API: Add description and visibility for stages
Split post fields and task fields in survey settings
Split post fields and task fields in post edit
Split post fields and task field in post detail
Remove 'completed' toggle from "Post"

Test these changes by:

Fixes ushahidi/platform#1283

Ping @ushahidi/platform

This change is

…cales, need to add support for require and visibility

coveralls · 2016-08-03T23:26:34Z

Coverage increased (+0.03%) to 51.301% when pulling 616f602 on 1283-survey-edit-update into 539b43e on develop.

…r task sections and for field items, next add author info

coveralls · 2016-08-09T13:43:23Z

Coverage decreased (-1.5%) to 50.82% when pulling a566493 on 1283-survey-edit-update into f566eb4 on develop.

coveralls · 2016-08-09T14:35:03Z

Coverage decreased (-1.6%) to 50.666% when pulling 6eacf3f on 1283-survey-edit-update into f566eb4 on develop.

coveralls · 2016-08-09T14:35:03Z

Coverage decreased (-1.6%) to 50.666% when pulling 6eacf3f on 1283-survey-edit-update into f566eb4 on develop.

coveralls · 2016-08-09T14:49:35Z

Coverage decreased (-1.6%) to 50.666% when pulling bf997cf on 1283-survey-edit-update into f566eb4 on develop.

…ompleted, fixed css for post values

coveralls · 2016-08-09T16:19:30Z

Coverage decreased (-1.6%) to 50.678% when pulling 099faab on 1283-survey-edit-update into f566eb4 on develop.

…rate task

coveralls · 2016-08-09T21:23:52Z

Coverage decreased (-1.6%) to 50.678% when pulling 129f3d2 on 1283-survey-edit-update into f566eb4 on develop.

rjmackay · 2016-08-10T01:28:36Z

I see what you mean about the complexity in post detail.. we should probably try to include a refactor in a future sprint.

Reviewed 1 of 7 files at r1, 1 of 9 files at r2, 1 of 2 files at r3, 3 of 7 files at r4.
Review status: 6 of 14 files reviewed at latest revision, 11 unresolved discussions, some commit checks broke.

app/post/detail/post-detail.controller.js, line 116 [r5] (raw file):

            }, $scope.form_attributes);

            // Make the first task visible

I'd prefer that we popped the post stage out of the tasks array ie. so tasks contains only tasks an post_task contains the post task.
Otherwise this is fragile and may break depending on ordering.

app/post/detail/post-detail.controller.js, line 125 [r5] (raw file):

                //Set post task id
                if (task.type === 'post') {

Can we add a note that this is assuming post has only a single 'post' stage ??

app/post/detail/post-value.directive.js, line 13 [r5] (raw file):

        templateUrl: 'templates/posts/post-detail-value.html',
        link: function ($scope) {
            $scope.standardTask = $scope.type === 'standard';

... what is this for? Whats a standard task?

server/www/templates/settings/surveys/modify/editor.html, line 264 [r5] (raw file):

                  <div class="form-field switch">
                     <label translate="survey.require_task">Require this task be completed before a post can be visible to the public</label>

This probably need a for attribute.

server/www/templates/settings/surveys/modify/editor.html, line 266 [r5] (raw file):

                     <label translate="survey.require_task">Require this task be completed before a post can be visible to the public</label>
                     <div class="toggle-switch">
                        <input class="tgl" id="switch1" type="checkbox" ng-model="task.required">

Please give this is sensible id

server/www/templates/settings/surveys/modify/editor.html, line 267 [r5] (raw file):

                     <div class="toggle-switch">
                        <input class="tgl" id="switch1" type="checkbox" ng-model="task.required">
                        <label class="tgl-btn" for="switch1" ng-click="toggleTaskRequired(task)"></label>

Why does this need ng-click shouldn't clicking the label toggle the value of a checkbox anyway?

server/www/templates/settings/surveys/modify/editor.html, line 274 [r5] (raw file):

                      <label translate="survey.show_task">Show this task to everyone when the post is published</label>
                      <div class="toggle-switch">
                          <input class="tgl" id="custom-show" type="checkbox" ng-model="task.is_public">

needs a sane id

server/www/templates/settings/surveys/modify/survey-task-create.html, line 7 [r5] (raw file):

  </div>
  <div class="form-field">
      <label translate="survey.task_description">

needs a for attribute

server/www/templates/settings/surveys/modify/survey-task-create.html, line 15 [r5] (raw file):

     <label translate="survey.require_task">Require this task be completed before a post can be visible to the public</label>
     <div class="toggle-switch">
        <input class="tgl" id="switchnewtask" type="checkbox" ng-model="newTask.required">

Can we give this a better id like required-toggle?

server/www/templates/settings/surveys/modify/survey-task-create.html, line 20 [r5] (raw file):

  </div>
  <div class="form-field switch">
      <label translate="survey.show_task">Show this task to everyone when the post is published</label>

needs a for attribute

server/www/templates/settings/surveys/modify/survey-task-create.html, line 22 [r5] (raw file):

      <label translate="survey.show_task">Show this task to everyone when the post is published</label>
      <div class="toggle-switch">
          <input class="tgl" id="custom-show" type="checkbox" ng-model="newTask.is_public">

Needs a sane id value.

Comments from Reviewable

willdoran · 2016-08-11T21:03:54Z

Review status: 6 of 14 files reviewed at latest revision, 11 unresolved discussions, some commit checks broke.

app/post/detail/post-detail.controller.js, line 116 [r5] (raw file):