Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in editing post collections. #1407

Closed
spiral99-zz opened this issue Sep 22, 2016 · 8 comments
Closed

bug in editing post collections. #1407

spiral99-zz opened this issue Sep 22, 2016 · 8 comments
Assignees

Comments

@spiral99-zz
Copy link

spiral99-zz commented Sep 22, 2016

Expected behaviour

editing a collection should make observable changes to the selected colllection

Actual behaviour

Trying to edit a created collection doesn't seem to work as expected instead the feature creates a new collection while retaining the unedited collection.

Steps to reproduce the behaviour/error

  1. Login to your deployment
  2. Click on the collection icon on the bottom left of the page and create a new collection.
  3. Click on the created collectioncand attempt to edit.
    2016-09-22 1
    2016-09-22 2
    2016-09-22
@rjmackay
Copy link
Contributor

Thanks for the bug report @spiral99
I think this is a duplicate of #1402 .. though you've provided MUCH more info thanks!

@willdoran
Copy link
Contributor

@rjmackay I just fixed 1402, it's PR is up on the repo

@rjmackay
Copy link
Contributor

@willdoran I see ushahidi/platform-client#355 which fixed #1413
but not #1402

Am I missing something?

@willdoran
Copy link
Contributor

@rjmackay I think that was a typo on my part I meant #1413

@rjmackay rjmackay added this to the Sprint 14 milestone Oct 31, 2016
rjmackay added a commit to ushahidi/platform-client that referenced this issue Nov 9, 2016
- Move collection toggles alongside other collections code
- Refactor collection editor to use ModalService
- Refactor collection listing to use ModalService
- Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407)
- Update modal container to accept a plain object, not just scopes
-
rjmackay added a commit to ushahidi/platform-client that referenced this issue Nov 9, 2016
- Move collection toggles alongside other collections code
- Refactor collection editor to use ModalService
- Refactor collection listing to use ModalService
- Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407)
- Update modal container to accept a plain object, not just scopes
-
rjmackay added a commit to ushahidi/platform-client that referenced this issue Nov 9, 2016
- Move collection toggles alongside other collections code
- Refactor collection editor to use ModalService
- Refactor collection listing to use ModalService
- Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407)
- Update modal container to accept a plain object, not just scopes
- Clean up collections-controller
rjmackay added a commit to ushahidi/platform-client that referenced this issue Nov 10, 2016
- Move collection toggles alongside other collections code
- Refactor collection editor to use ModalService
- Refactor collection listing to use ModalService
- Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407)
- Update modal container to accept a plain object, not just scopes
- Clean up collections-controller
@rjmackay
Copy link
Contributor

@jshorland
Copy link

jshorland commented Nov 10, 2016

Editing name of collection is successful.

Editing default view does not work immediately, or upon refresh. (see gif attached)

Editing permissions is ok to change only upon returning to the collection/refreshing.

screen capture on 2016-11-10 at 14-50-55

rjmackay added a commit to ushahidi/platform-client that referenced this issue Nov 11, 2016
- Move collection toggles alongside other collections code
- Refactor collection editor to use ModalService
- Refactor collection listing to use ModalService
- Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407)
- Update modal container to accept a plain object, not just scopes
- Clean up collections-controller
@rjmackay
Copy link
Contributor

I think setting view mode works as expected. You can view a collection with either map or timeline view.. the default is just the default with you first navigate to it. It won't change mode when you reload the view, because the URL is /collections/5/list or /collections/5/map. That is the way this worked prior to this change too

To test

  1. Open collections menu and click on a collection
  2. Edit collection and set default viewing mode to 'map'
  3. Save the collection
  4. Open collections menu and click on the same collection
    It will take you to the map.
    Repeat with timeline mode.

@rjmackay
Copy link
Contributor

I'm going to land the change since it fixes the original bug. I can do a follow up if the default view behaviour is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants