-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in editing post collections. #1407
Comments
@rjmackay I just fixed 1402, it's PR is up on the repo |
@willdoran I see ushahidi/platform-client#355 which fixed #1413 Am I missing something? |
- Move collection toggles alongside other collections code - Refactor collection editor to use ModalService - Refactor collection listing to use ModalService - Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407) - Update modal container to accept a plain object, not just scopes -
- Move collection toggles alongside other collections code - Refactor collection editor to use ModalService - Refactor collection listing to use ModalService - Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407) - Update modal container to accept a plain object, not just scopes -
- Move collection toggles alongside other collections code - Refactor collection editor to use ModalService - Refactor collection listing to use ModalService - Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407) - Update modal container to accept a plain object, not just scopes - Clean up collections-controller
- Move collection toggles alongside other collections code - Refactor collection editor to use ModalService - Refactor collection listing to use ModalService - Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407) - Update modal container to accept a plain object, not just scopes - Clean up collections-controller
- Move collection toggles alongside other collections code - Refactor collection editor to use ModalService - Refactor collection listing to use ModalService - Fix bugs with collection editor showing wrong collection (ushahidi/platform#1407) - Update modal container to accept a plain object, not just scopes - Clean up collections-controller
I think setting view mode works as expected. You can view a collection with either map or timeline view.. the default is just the default with you first navigate to it. It won't change mode when you reload the view, because the URL is To test
|
I'm going to land the change since it fixes the original bug. I can do a follow up if the default view behaviour is a problem. |
Expected behaviour
editing a collection should make observable changes to the selected colllection
Actual behaviour
Trying to edit a created collection doesn't seem to work as expected instead the feature creates a new collection while retaining the unedited collection.
Steps to reproduce the behaviour/error
The text was updated successfully, but these errors were encountered: