Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination on saved search not working #1484

Closed
aoduor opened this issue Nov 6, 2016 · 2 comments
Closed

Pagination on saved search not working #1484

aoduor opened this issue Nov 6, 2016 · 2 comments
Assignees
@jshorland
Labels
Bug

Comments

@aoduor
Copy link
Member

aoduor commented Nov 6, 2016 •
edited by jshorland
Loading

Expected behaviour

I've got a listing of 3 pages on my saved search. When i click on the "next" button or any page number indicated on the bottom of my page, it should take me to the next page populated with more content in my saved search.

screenshot

Actual behaviour

Clicking on either page number or the "next/back" buttons takes me to a page saying "Your search didn't match any posts"

Steps to reproduce the behaviour/error

  • Click on a saved search
  • Attempt to navigate to another page within the same saved search
rjmackay added a commit that referenced this issue Nov 8, 2016
@rjmackay
Allow ?status[]=all as a post filter
9809c05 
We already accept ?status=all but not in a array form. This breaks
on the client, but is also just inconsistent.

Refs #1484
rjmackay added a commit to ushahidi/platform-client that referenced this issue Nov 8, 2016
@rjmackay
Handle filtering posts to 'all' statuses better
4d43939 
Replace status=all in post filters with full set of possible statuses.
This display better in active filters and avoids weird bugs.

Refs ushahidi/platform#1484
@rjmackay rjmackay mentioned this issue Nov 8, 2016
Merged
@rjmackay
Copy link
Contributor

rjmackay commented Nov 8, 2016

This was related to weird handling of the post status filter. It should be fixed on production now.

@jshorland
Copy link

Fixed in production. Thanks. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshorland jshorland

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjmackay @aoduor @jshorland