Notifications are never queued

[rjmackay]

1. Create a saved search for post within 100km of Auckland
2. Set up notifications: email + SMS
3. Add a new post with location Auckland.
4. Confirm post shows up in saved search.
   Expected: messages queued to send
   Actual: No messages are ever queued

[rjmackay]

@jasonmule can you look into this? I haven't tried to reproduce locally yet.
This is a problem for the KRC deployment so needs to get fixed asap

[jasonmule]

I tried to reproduced this locally and it's possible that this fails because of the following reasons:

1. The user has not subscribed to notifications. When the user adds a notification for the first time, it's probably a good idea to direct them to manage their notifications and add at least one contact.
2. The post has not been published. At the moment we only send out notifications for published posts.

The following commands queue notifications for saved searches:

1 . Find posts from saved searches

bin/ushahidi savedsearch

2 . Queue notifications

bin/ushahidi notification queue

[snilsmitchell]

When I tried at krcs.ushahidi.io, I checked that I was subscribed to notifications before publishing a post, and made sure that the post had been published (and all post steps completed). The notification was still not sent.

[jasonmule]

Thanks @sebm90. We should probably still remind you to add a contact if you don't have one when you subscribe.

[snilsmitchell]

@jasonmule Could you explain what adding a contact involves? Aren't my own contact details (my email, which is already in the system) enough? Does this need to be a different person?

[jasonmule]

@rjmackay Did you run bin/ushahidi savedsearch ?

[jasonmule]

@sebm90 Could you go to Manage notifications and check that your email contact is turned on to receive notifications?

[ushbot]

@jasonmule I was testing on staging. I haven't tried to reproduce locally yet. I'll do that today.

The post has not been published. At the moment we only send out notifications for published posts.

That might have been my issue.. though I thought I tested both. I definitely enabled notifications in the UI.

[rjmackay]

oops that was me not a bot.

[snilsmitchell]

@jasonmule My email contact is turned on and was turned on when I tested notifications:

[rjmackay]

Just reproduced the issue locally for myself.
bin/ushahidi savedsearch yields " 2 posts were added "
But then bin/ushahidi notifications queue says "0 messages queued for sending"

[rjmackay]

Looking in the DB. posts_sets is being populated for the posts I added, but only for the default sets: All post, and published posts. Its not picking up the saved search for post near Auckland that I added.

[rjmackay]

Looks like the saved search criteria includes some values which get filtered out by the client, but don't work when used directly on the server. ie. form = 'none'
We'll need to fix our handling for those on both client and server I think

[jasonmule]

@rjmackay When the saved searches were added, was there a contact turned on to receive notifications? Could you clarify the bit about only default sets?

[jasonmule]

So the savedsearch task uses the filters saved with the saved search. The only way I was able to reproduce the issue where 0 messages were queued is when there is no contact subscribed to the queued posts.

[rjmackay]

Looks like this was dependent on state - filters from previous searches leaked into the next one.