Move code out of kohana application #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmackay
changed the title
rjmackay
force-pushed
the
lumen-move-code-out-of-kohana-application
branch
2 times, most recently
from
826f80c to
c644ab0
Compare
- Move all commands into src/Console - Move everything else into src/App - Move console DI setup into src/Console/Init.php - Namespace all the things
rjmackay
force-pushed
the
lumen-move-code-out-of-kohana-application
branch
from
5ab025a to
5d2af5f
Compare
rjmackay
force-pushed
the
lumen-move-code-out-of-kohana-application
branch
2 times, most recently
from
337b64f to
0f99a5f
Compare
willdoran
reviewed
May 25, 2017
| protected function getTable() | ||
| { | ||
| return 'post_datetime'; | ||
| } | ||
|
|
||
| private function convertToMysqlFormat($value) { | ||
| private function convertToMysqlFormat($value) | ||
| { |
There was a problem hiding this comment.
Is this a formatting issue?
rjmackay
force-pushed
the
lumen-move-code-out-of-kohana-application
branch
from
0f99a5f to
7464939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test these changes by:
Refs #1372
Ping @ushahidi/platform
This change is