Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore form.tags if passed when saving Form entities #1755

Merged
merged 1 commit into from
May 25, 2017
Merged

Ignore form.tags if passed when saving Form entities #1755

merged 1 commit into from
May 25, 2017

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented May 25, 2017 •
edited
Loading

This pull request makes the following changes:

  • Ignore computed attributes on form

Test these changes by:

  • Save a form
  • Ensure tests pass

This change is Reviewable

@rjmackay
Ignore form.tags if passed when saving Form entities
1616676 
Ignore computed attributes on form
willdoran
willdoran approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@willdoran willdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@rjmackay rjmackay merged commit 344fc16 into develop May 25, 2017
@rjmackay rjmackay deleted the fix-saving-form branch May 25, 2017 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdoran willdoran willdoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmackay @willdoran