Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse tag names when set as post value (not just post.tags) #1758

Merged
merged 1 commit into from
May 26, 2017
Merged

Parse tag names when set as post value (not just post.tags) #1758

merged 1 commit into from
May 26, 2017

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented May 26, 2017 •
edited
Loading

This pull request makes the following changes:

  • Parse tags as name or id when sent in post.values. We already do this
    with post.tags

Test these changes by:

  • bin/behat
  • Import a CSV with category names in 1 column. Map that column to a CSV field and confirm that it imports OK

Refs #1397

Ping @ushahidi/platform

This change is Reviewable

@rjmackay
Parse tag names when set as post value (not just post.tags)
071e061 
Parse tags as name or id when sent in post.values. We already do this
with post.tags
@rjmackay rjmackay requested review from willdoran and Angamanga May 26, 2017 05:01
Angamanga
Angamanga approved these changes May 26, 2017
View reviewed changes
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine when uploading a csv with category-names from the client!

@rjmackay rjmackay merged commit 7f97320 into develop May 26, 2017
@rjmackay rjmackay deleted the parse-tag-values branch May 26, 2017 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angamanga Angamanga Angamanga approved these changes

@willdoran willdoran Awaiting requested review from willdoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmackay @Angamanga