Add ushahidi/kohana-validation package and use that #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willdoran can you review? |
rjmackay
commented
Jun 8, 2017
|
|
||
| public function getTranslationCallback() | ||
| { | ||
| return function ($file, $field, $error = null) { |
There was a problem hiding this comment.
This is probably the ugliest bit. We pass a callback into the KohanaValidation lib for translating messages, and do some wrangling here to connect that to lumen's translator.
rjmackay
commented
Jun 8, 2017
| @@ -27,8 +26,8 @@ | |||
| * @param $validation_factory | |||
| * @return void | |||
| */ | |||
| public function setValidation(InstanceFactory $validation_factory) | |||
| public function setValidation(ValidationEngine $validation_engine) | |||
There was a problem hiding this comment.
Not sure why this was set up so weirdly. Cleaner now
rjmackay
force-pushed
the
lumen-separate-validation-from-kohana
branch
from
a2a99a7 to
e445c2d
Compare
|
@rjmackay This is to stablise validation during transition? |
Yup. We need to drop Kohana ASAP, so this just keeps the couple of classes we need in the interrim. |
This replaces the dependencies on Kohana Core. - Update Validators to refer to namespaced Valid and Validation class - Fix DI for ValidationEngineTrait - Set up translations - Move error messages to laravel language files
rjmackay
force-pushed
the
lumen-separate-validation-from-kohana
branch
from
e445c2d to
a0f3d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the dependencies on Kohana Core.
Test checklist:
Refs #1372
Ping @ushahidi/platform