-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lumen db without kohana #1802
Lumen db without kohana #1802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid \ style I find it jarring and inconsistent.
src/App/Multisite.php
Outdated
use League\Url\Url; | ||
|
||
class Ushahidi_Multisite | ||
class Multisite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much better naming scheme. Dir structure should be a clear, consistent way to traverse the source.
... I'm not clear what you're talking about? Do you mean the |
f37b7ac
to
79739e8
Compare
Updated to remove |
79739e8
to
2b0a46a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the tests, I think that's just linting
2b0a46a
to
5ba6ee3
Compare
This pull request makes the following changes:
Test checklist:
Refs #1372
Ping @ushahidi/platform