Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lumen db without kohana #1802

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Lumen db without kohana #1802

merged 2 commits into from
Jul 4, 2017

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Jun 13, 2017

This pull request makes the following changes:

Test checklist:

  • bin/behat

Refs #1372

Ping @ushahidi/platform

Copy link
Contributor

@willdoran willdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to avoid \ style I find it jarring and inconsistent.

use League\Url\Url;

class Ushahidi_Multisite
class Multisite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better naming scheme. Dir structure should be a clear, consistent way to traverse the source.

@rjmackay
Copy link
Contributor Author

rjmackay commented Jul 3, 2017

Is there a way to avoid \ style I find it jarring and inconsistent.

... I'm not clear what you're talking about? Do you mean the \Ohanzee\Database type references? The \ prefix is necessary because we're in a namespace. The alternative is to insist on use statements instead... I can definitely do that, it just requirement more than find and replace.

@rjmackay rjmackay force-pushed the lumen-db-without-kohana branch from f37b7ac to 79739e8 Compare July 3, 2017 02:37
@rjmackay
Copy link
Contributor Author

rjmackay commented Jul 3, 2017

Updated to remove \Ohanzee\DB and use Ohanzee\DB instead.

@rjmackay rjmackay force-pushed the lumen-db-without-kohana branch from 79739e8 to 2b0a46a Compare July 3, 2017 03:39
Copy link
Contributor

@willdoran willdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the tests, I think that's just linting

@rjmackay rjmackay force-pushed the lumen-db-without-kohana branch from 2b0a46a to 5ba6ee3 Compare July 4, 2017 22:05
@rjmackay rjmackay merged commit 0d91a04 into lumen Jul 4, 2017
@rjmackay rjmackay deleted the lumen-db-without-kohana branch July 4, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants